Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DOCS-362 - Log Search Behavior Insights refactor #4869

Merged
merged 8 commits into from
Dec 19, 2024
Merged

DOCS-362 - Log Search Behavior Insights refactor #4869

merged 8 commits into from
Dec 19, 2024

Conversation

kimsauce
Copy link
Collaborator

@kimsauce kimsauce commented Dec 12, 2024 •
edited
Loading

Purpose of this pull request

This pull request refactors Log Search Behavior Insights content per @banant

Select the type of change

  • Minor Changes - Typos, formatting, slight revisions
  • Update Content - Revisions, updating sections
  • New Content - New features, sections, pages, tutorials
  • Site and Tools - .clabot, version updates, maintenance, dependencies, new packages for the site (Docusaurus, Gatsby, React, etc.)

Ticket (if applicable)

https://sumologic.atlassian.net/browse/DOCS-362

@kimsauce kimsauce self-assigned this Dec 12, 2024
@cla-bot cla-bot bot added the cla-signed Contributor approved, listed in .clabot file label Dec 12, 2024
@kimsauce kimsauce added the do-not-merge Pull requests that should not be merged label Dec 12, 2024
jpipkin1
jpipkin1 requested changes Dec 12, 2024
View reviewed changes
Copy link
Collaborator

@jpipkin1 jpipkin1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work, @kimsauce! I suggest you look at all the index articles affected by the move and make sure that the cards show the correct child articles.

@kimsauce kimsauce requested a review from jpipkin1 December 13, 2024 02:08
@kimsauce
Copy link
Collaborator Author

Nice work, @kimsauce! I suggest you look at all the index articles affected by the move and make sure that the cards show the correct child articles.

Thank you for this catch @jpipkin1 ! Just made the fixes - can you re-review pls?

@jpipkin1
Copy link
Collaborator

Your fixes look good. I made one more tweak (see commit "Move 'Lookup Tables' in index").

@kimsauce kimsauce enabled auto-merge December 19, 2024 03:04
@kimsauce kimsauce added this pull request to the merge queue Dec 19, 2024
Merged via the queue into main with commit 372da06 Dec 19, 2024
7 checks passed
@kimsauce kimsauce deleted the DOCS-362 branch December 19, 2024 03:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jpipkin1 jpipkin1 jpipkin1 approved these changes

@JV0812 JV0812 Awaiting requested review from JV0812 JV0812 is a code owner

@mafsumo mafsumo Awaiting requested review from mafsumo mafsumo is a code owner

@amee-sumo amee-sumo Awaiting requested review from amee-sumo amee-sumo is a code owner

Assignees

@kimsauce kimsauce

Labels
cla-signed Contributor approved, listed in .clabot file do-not-merge Pull requests that should not be merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kimsauce @jpipkin1